Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit package-lock.json ? #93

Open
cdeil opened this issue Sep 15, 2017 · 1 comment
Open

Commit package-lock.json ? #93

cdeil opened this issue Sep 15, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@cdeil
Copy link
Contributor

cdeil commented Sep 15, 2017

@vorugantia - Should we commit package-lock.json?
I keep getting this warning:

$ npm install
npm notice created a lockfile as package-lock.json. You should commit this file.

and this file keeps getting generated and show up with git status:

$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	package-lock.json

nothing added to commit but untracked files present (use "git add" to track)

So we should either commit it, or add it to .gitignore.

@vorugantia - I think we should just commit it, no? If you have time, could you read around a bit how it's used (i.e. how one updates it as new versions of the dependencies pinned there appear), and add a link or two to a good reference to the gamma-sky.net dev docs?

@cdeil cdeil added the question label Sep 15, 2017
@cdeil cdeil added this to the Version 0.2 milestone Sep 15, 2017
@ShankariManohar
Copy link

You can use "git add -A" in cmd to commit the package-lock.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants