Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fb check list from srv res #106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

nspielbau
Copy link
Contributor

Fixes #14 for ROS 2

@nspielbau nspielbau changed the base branch from main to dev September 26, 2024 11:07
Copy link

github-actions bot commented Sep 26, 2024

Test Results

  4 files  ±0    4 suites  ±0   56s ⏱️ ±0s
181 tests ±0  181 ✅ ±0  0 💤 ±0  0 ❌ ±0 
724 runs  ±0  724 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fd25328. ± Comparison against base commit e795e62.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.43%. Comparing base (e795e62) to head (fd25328).

Files with missing lines Patch % Lines
ros_bt_py/ros_bt_py/ros_nodes/action.py 25.00% 3 Missing ⚠️
ros_bt_py/ros_bt_py/node_data.py 33.33% 2 Missing ⚠️
ros_bt_py/ros_bt_py/ros_helpers.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   33.36%   33.43%   +0.06%     
==========================================
  Files          39       39              
  Lines        5805     5817      +12     
  Branches     1329     1331       +2     
==========================================
+ Hits         1937     1945       +8     
- Misses       3805     3808       +3     
- Partials       63       64       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nspielbau nspielbau self-assigned this Oct 9, 2024
Copy link
Contributor

@Oberacda Oberacda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also do this for all Topic and Parameter nodes to have consistency across the ROS nodes.

Base automatically changed from dev to main October 28, 2024 10:55
@Oberacda Oberacda added this to the v0.2.x milestone Oct 28, 2024
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetAttr can't access int16[] field as list
3 participants