-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: add jerk to CartesianTrajectoryPoint #3
Comments
Not necessarily a counter-argument, but doesn't a jerk also make sense in the joint-based case? As the JointTrajectoryPoint does not contain one, my first attempt was to omit it here, as well. However, I absolutely understadn that this is a point worth discussing. |
I'm sort of assuming I'd also say that |
Interesting. I'm not familiar with those details of PR2, suggest asking @tfoote ? I'm a big fan of iteration. Things can always be improved! |
@codebot: apologies for dragging you into this discussion then. I was somehow sure you were involved in the hw/electronics design of PR2 as well. |
haha all good! I wish I was involved 😄 the PR2 electronics and low-level controls are seriously awesome! |
I second this. |
So, if we add a jerk, what should be the datatype? It feels like having a jerk on a per-dimension level would make sense as we have this for all other fields, as well. Additionally, this would only make sense if there would be an underlying controller taking this into account, as well. |
My suggestion (from #3 (comment)):
We could host that message wherever the new Cartesian msgs end up, for now. Ideally we'd revive ros/common_msgs#137 and get it merged there, but that could take a while.
Well, I'd say that would result in the best execution of the trajectory. That would be OK, as long as the components responsible for execution are clear about this. |
Defined this in #11 the datatype is noted as to be determined. |
In cases where this message would be used to communicate Cartesian trajectories to (interpolating) trajectory generators, being able to specify a max or desired jerk per trajectory point would be advantageous.
The current proposal doesn't include it, so the suggestion would be to add it -- similar to how the reviewed johnmichaloski example has it.
As there is no
geometry_msgs/Jerk
, it would probably require a custom message. Although it would essentially be a copy ofgeometry_msgs/Accel
andgeometry_msgs/Twist
but with different semantics.The text was updated successfully, but these errors were encountered: