fix: travelperk not loading all invoice profiles #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integrate with the travelperk pagination API to fetch invoice profiles from all pages
JustARatherRidiculouslyLongUsername
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
PR description must contain a link to a ClickUp (case-insensitive) |
|
ruuushhh
reviewed
Oct 21, 2024
ruuushhh
requested changes
Oct 21, 2024
JustARatherRidiculouslyLongUsername
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
PR description must contain a link to a ClickUp (case-insensitive) |
|
ruuushhh
reviewed
Oct 21, 2024
…nd create an implementation in `InvoiceProfiles`
JustARatherRidiculouslyLongUsername
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
JustARatherRidiculouslyLongUsername
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
ruuushhh
approved these changes
Oct 22, 2024
|
JustARatherRidiculouslyLongUsername
added
the
deploy
JustARatherRidiculouslyLongUsername
had a problem deploying
to
CI Environment
GitHub Actions
Failure
JustARatherRidiculouslyLongUsername
temporarily deployed
to
Staging
GitHub Actions
Inactive
JustARatherRidiculouslyLongUsername
merged commit cb67842
into
master
5 of 6 checks passed
JustARatherRidiculouslyLongUsername
added a commit
that referenced
this pull request
Oct 24, 2024
* fix: travelperk not loading all invoice profiles integrate with the travelperk pagination API to fetch invoice profiles from all pages * refactor: move `get_all_generator` to `ApiBase` and rename variable * fix: generalise the `get_all_generator` method for all onject types and create an implementation in `InvoiceProfiles` * refactor: clarity (cherry picked from commit cb67842)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
integrate with the travelperk pagination API to fetch invoice profiles from all pages
Before:
After:
Clickup
app.clickup.com