Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle VCS endpoint-defined package #201

Open
pmaselkowski opened this issue Mar 9, 2016 · 0 comments
Open

Handle VCS endpoint-defined package #201

pmaselkowski opened this issue Mar 9, 2016 · 0 comments

Comments

@pmaselkowski
Copy link

When installed package has endpoint-defined dep it fails with error message:

  [Seld\JsonLint\ParsingException]                                               
  "https://bower.herokuapp.com/packages/player-api" does not contain valid JSON  
  Parse error on line 1:                                                         
  Package not found                                                              
  ^                                                                              
  Expected one of: 'STRING', 'NUMBER', 'NULL', 'TRUE', 'FALSE', '{', '['   

Note: url https://bower.herokuapp.com/packages/player-api returns 404 but it's still being parsed. Anyway should it even check bower if has endpoint instead of version?

My proposal is to either handle installing from endpoint (probably complicated), or at least display more meaningful message, like "Package player-api not found while installing maslosoft-playlist".

Details:

Dependencies of installed package:

{
    "name":"maslosoft-playlist",
      "dependencies": {
        "jquery": "~2",
        "font-awesome": "fontawesome#~4",
        "bootstrap": "~3",
        "player-api": "https://github.com/vimeo/player-api" 
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants