Added XLS export with xlsxwriter #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this pull request. Looks good to me. I have one additional request. "xlsxwriter" is an additional module one has to install via pip. Is this correct? If this is the case, could you please adapt the "ExportReportXLSCommand" and try to import "xlsxwriter", catch the error if any, and display a info to the user? Something like "It looks like 'xlsxwriter' could not be found on your system. To install it ...." Otherwise an exception will be thrown if the command is startet and xlsxwriter is not installed. |
|
Yes, that is a good point. Added import check and message with the link to the documentation. |
|
@furti ? |
|
I'm sorry. I'm pretty busy right now. Maybe i have some time to merge it the upcoming week |
|
@furti any progress on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added the possibility to export selected report to .xlsx file.