Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated response type of router.get('/') in Part9c.md #3855

Open
wants to merge 1 commit into
base: source
Choose a base branch
from
Open

Updated response type of router.get('/') in Part9c.md #3855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/content/9/en/part9c.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ import { Response } from 'express'

// ...

router.get('/', (_req, res: Response<DiaryEntry[]>) => {
router.get('/', (_req, res: Response<NonSensitiveDiaryEntry[]>) => {
res.send(diaryService.getNonSensitiveEntries());
});

Expand Down Expand Up @@ -1719,7 +1719,7 @@ router.post('/', (req, res) => { // highlight-line

Instead of calling the request body parsing method explicitly in the route handler, the validation of the input could also be done in a middleware function.

We have also add the type definitions to the route handler parameters, and shall use types also in the middleware function _newDiaryParser_:
We have also added the type definitions to the route handler parameters, and shall use types as well in the middleware function _newDiaryParser_:

```js
const newDiaryParser = (req: Request, _res: Response, next: NextFunction) => {
Expand All @@ -1732,7 +1732,7 @@ const newDiaryParser = (req: Request, _res: Response, next: NextFunction) => {
};
```

The middleware just calls the schema parser to the request body. If the parsing throws an exception, that is passed to the error handling middleware.
The middleware just calls the schema parser on the request body. If the parsing throws an exception, it is passed to the error handling middleware.

So after the request passes this middleware, it <i>is known that the request body is a proper new diary entry</i>. We can tell this fact to TypeScript compiler by giving a type parameter to the _Request_ type:

Expand Down