Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model vs marketing name, cleaning up existing Gluon device names #2968

Open
Djfe opened this issue Sep 5, 2023 · 2 comments
Open

model vs marketing name, cleaning up existing Gluon device names #2968

Djfe opened this issue Sep 5, 2023 · 2 comments

Comments

@Djfe
Copy link
Contributor

Djfe commented Sep 5, 2023

This is a continuation of questions that arose from #2966
Let's create a new issue to discuss this under ^^

Gluon uses model names for it's devices. But it doesn't do it for all supported devices, yet.
I could fix this with a PR, if desired. What's the maintainers' opinion on that?


The Mikrotik hAP AC² should/could actually be renamed to RBD52G-5HacD2HnD-TC?

device('mikrotik-hap-ac2', 'mikrotik_hap-ac2', {

here it says hAP in brackets
Would additional names in the supported_devices.rst be allowed? I feel like they have a use.

- RB951Ui-2nD (hAP)

Zyxel WSM20 (Multy M1) <- would work for me, but your decision.

More examples where the marketing name was preferred:
https://github.com/freifunk-gluon/gluon/blob/master/docs/user/supported_devices.rst?plain=1#L239-L241


same goes for Aruba:

model name appears to be actually: APIN0303

An example of the labels Aruba prints on the back of their devices:
Aruba InstantOn AP12 (RW)
908055851664444CC8034ED09F2DEEF7
InstantOn AP11(D)/AP17 are clearly marketing and not model names.

@Djfe Djfe changed the title gluon device names: model name vs marketing name, cleaning up existing device names model vs marketing name, cleaning up existing Gluon device names Sep 5, 2023
@neocturne
Copy link
Member

Naming in the target files is determined by OpenWrt, this must match what libplatforminfo reports for the autoupdater to work (adding aliases or manifest aliases when different devices use the same image or image names have changed). If the name of a device is wrong, that is a bug and must be fixed.

In the docs, listing alternative marketing names sense.

@Djfe
Copy link
Contributor Author

Djfe commented Sep 11, 2023

I just stumbled across devolo and their MT numbers.
Those are probably just type numbers and don't count as a model name, right?
https://www.devolo.de/support/ce

Example:
the devolo WiFi pro 1750e has MT: 2785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants