-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batchnorm and masking #46
Comments
I think Batchnorm is per dimension, so the masked part will not affect the unmasked part? |
That's the time-index, not the dimension.
…On Mon, Nov 9, 2020 at 10:18 PM Yiming Wang ***@***.***> wrote:
I think Batchnorm is per dimension, so the padding part will not affect
the "real" part?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLO5N6MCSXHVDFPG7CUDSO723LANCNFSM4TPMB55A>
.
|
Oh OK. How does Kaldi deal with it? Guarantee same length within a batch so no padding? |
Issue doesn't arise in Kaldi, we use regular minibatches.
In Lhotse our plan would be to use lhotse itself to do padding (which would
add silence or noise). So we wouldn't be messing about with zeros
throughout the propagation,it would be a real signal.
But I expect batchnorm may support a mask matrix.
…On Mon, Nov 9, 2020 at 11:50 PM Yiming Wang ***@***.***> wrote:
Oh OK. How does Kaldi deal with it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLO3G7C4MXSNFEGGLTPTSPAFSVANCNFSM4TPMB55A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like the batchnorm doesn't take into account the masking:
espresso/espresso/models/speech_tdnn.py
Line 170 in 6fca6ca
Surely this isn't right?
However I don't know how to take it into account.
The text was updated successfully, but these errors were encountered: