Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dissalow contributor to update own role #340

Closed
wants to merge 2 commits into from
Closed

fix: dissalow contributor to update own role #340

wants to merge 2 commits into from

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Nov 17, 2023 •
edited
Loading

Checklist:

Closes #336

@Sembauke Sembauke requested a review from a team as a code owner November 17, 2023 09:31
@Sembauke Sembauke marked this pull request as draft November 17, 2023 09:33
@Sembauke Sembauke marked this pull request as ready for review November 17, 2023 10:25
ojeytonwilliams
ojeytonwilliams requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't address the underlying issue. It isn't a problem for a user to GET their own data, but it's a serious problem if they can make arbitrary changes to it.

@Sembauke
Copy link
Member Author

Sembauke commented Nov 17, 2023 •
edited
Loading

@ojeytonwilliams
Alright, I can check if we can disallow the PUT only, but I am not sure we can.

@Sembauke Sembauke marked this pull request as draft November 17, 2023 11:11
@ojeytonwilliams
Copy link
Contributor

We can, by removing the permission from the roles. However, I don't think that's enough, because the route still allows the users that can call it complete control over their own user record. That's bound to cause problems.

@Sembauke Sembauke closed this Nov 20, 2023
@Nirajn2311 Nirajn2311 deleted the fix/contributor-updating-own-role branch November 22, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams ojeytonwilliams requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Privilege escalation
2 participants
@Sembauke @ojeytonwilliams