Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin to compatibility with current eventyay-talk #7

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

odkhang
Copy link
Contributor

@odkhang odkhang commented Aug 1, 2024

Summary by Sourcery

This pull request updates the plugin to be compatible with eventyay-talk by changing the plugin metadata, including the name and description, to reflect the new downstream service.

  • Enhancements:
    • Updated plugin metadata to reflect compatibility with eventyay-talk instead of pretalx.

Copy link

sourcery-ai bot commented Aug 1, 2024

Reviewer's Guide by Sourcery

This pull request updates the plugin to ensure compatibility with the current eventyay-talk system. The primary changes involve updating the verbose_name and description in the 'pretalx_downstream/apps.py' file to reflect the new system name and functionality.

File-Level Changes

Files Changes
pretalx_downstream/apps.py Updated references from 'pretalx' to 'eventyay-talk' to ensure compatibility with the current eventyay-talk system.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odkhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider updating the plugin name in the PretalxPluginMeta class to match the new 'eventyay-talk' naming convention for consistency with other changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling mariobehling merged commit 329649f into fossasia:main Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants