libfileref: fix segfault for files >2G #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: 'flux archive create' segfaults when it tries to archive files with size >2G. Change a local variable from int to size_t. Fixes flux-framework#6461
|
Thank you! 🙏 |
vsoch
approved these changes
Nov 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6462 +/- ##
==========================================
+ Coverage 83.61% 83.62% +0.01%
==========================================
Files 523 523
Lines 87547 87547
==========================================
+ Hits 73199 73214 +15
+ Misses 14348 14333 -15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: 'flux archive create' segfaults when it tries to archive files with size >2G.
Change a local variable from int to size_t.
Fixes #6461