Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve --include documentation in flux-resource(1) #6459

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Nov 22, 2024

@schoate had pointed out that the flux resource list --include option is difficult to discover because the option name itself isn't exactly obvious and the man page description of the option doesn't include the term "node' (only host and rank).

Update the -i, --include option documentation to include the word "node" for improved search.

Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

Problem: The flux-resource(1) documentation of the `-i, --include`
option doesn't include the word "node", which made is less likely
the option would pop up for a search on how to filter nodes in the
output of various subcommands.

Include "node" in the description of the `-i, --include` option. Make
the text for all instances of the `--include` option the same.
@mergify mergify bot merged commit af5feae into flux-framework:master Nov 22, 2024
32 checks passed
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (607c57e) to head (640631e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6459      +/-   ##
==========================================
- Coverage   83.63%   83.62%   -0.02%     
==========================================
  Files         523      523              
  Lines       87538    87538              
==========================================
- Hits        73209    73200       -9     
- Misses      14329    14338       +9     

see 9 files with indirect coverage changes

---- 🚨 Try these New Features:

@grondo grondo deleted the resource-list-doc branch November 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants