Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clang-format #6440

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update clang-format #6440

wants to merge 4 commits into from

Commits on Nov 14, 2024

  1. update clang-format 

    Problem: .clang-format is out of sync with project style.

This uses some newer options (clang 11) to get it a little closer.

Originally proposed in flux-framework#4694
    @trws @garlick
    trws authored and garlick committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f51d072 View commit details
    Browse the repository at this point in the history

  2. clang-format: limit columns to 80 chars 

    Problem: the column limit of 88 chars is inconsistent with
current project practices.

Set the limit to 80 chars.
    @garlick
    garlick committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0bf2a7a View commit details
    Browse the repository at this point in the history

  3. clang-format: drop ancient clang version ref 

    Problem: a comment about requiring clang-3.6 or clang-7 is
probably no longer useful at this point as those releases
are now old.

Drop comment.
    @garlick
    garlick committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8db230f View commit details
    Browse the repository at this point in the history

  4. clang-format: add AlignConsecutiveMacros 

    Problem: the current clang-format removes alignment of the
values of consecutive macro assignments, which makes things
less readable.

clang-20 adds AlignConsecutiveMacros.
Add it so we'll be ready.
    @garlick
    garlick committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f5484bb View commit details
    Browse the repository at this point in the history