-
Notifications
You must be signed in to change notification settings - Fork 11
Replace/Remove SVN keywords from API script. #7
Comments
Both the license headers of
must be fixed. |
Copyright years must be updated. |
flowplayer-src.js is fixed and pushed to releases.flowplayer.org (copyright year also) |
No. flashembed.js + flowplayer-src.js must be concatenated into flowplayer-<version>.js |
It's probably a matter of omitting the removal of flowplayer.js before uglification. |
flashembed.js still has the svn keywords and other unexpanded vars: https://github.com/flowplayer/flash/blob/master/core/src/javascript/flashembed.js |
Proposal: /**
* Flashembed - New wave Flash embedding
*
* NO COPYRIGHTS OR LICENSES. DO WHAT YOU LIKE.
*/ for the non-minified version - removed automatically in the minified version. |
@anssip - the copyright year is still 2008-2011 in flowplayer-src.js |
@anssip - now all version information is removed from the scripts. |
This is still not ideal. The build script should: - add release version and number to all published JS files flowplayer/flash-build#7 - create and publish the unminified api flowplayer/flash-build#6
Distributing the script with the following in the license header:
[sic] just looks clumsy.
@anssip - do you have something in place to expand these via Makefile:
Or should they just be removed?
The text was updated successfully, but these errors were encountered: