Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Replace/Remove SVN keywords from API script. #7

Open
phloxic opened this issue Nov 7, 2013 · 9 comments
Open

Replace/Remove SVN keywords from API script. #7

phloxic opened this issue Nov 7, 2013 · 9 comments

Comments

@phloxic
Copy link

phloxic commented Nov 7, 2013

Distributing the script with the following in the license header:

 * Date: ${date}
 * Revision: ${revision}

[sic] just looks clumsy.

@anssip - do you have something in place to expand these via Makefile:

 * Date: @DATE
 * Revision: @REVISION

Or should they just be removed?

@phloxic
Copy link
Author

phloxic commented Nov 7, 2013

Both the license headers of

  • flowplayer-src.js
  • flashembed.js

must be fixed.

@phloxic
Copy link
Author

phloxic commented Nov 7, 2013

Copyright years must be updated.

@anssip
Copy link
Contributor

anssip commented Dec 20, 2013

flowplayer-src.js is fixed and pushed to releases.flowplayer.org (copyright year also)

@phloxic
Copy link
Author

phloxic commented Dec 20, 2013

No. flashembed.js + flowplayer-src.js must be concatenated into flowplayer-<version>.js

@phloxic
Copy link
Author

phloxic commented Dec 20, 2013

It's probably a matter of omitting the removal of flowplayer.js before uglification.

@phloxic
Copy link
Author

phloxic commented Dec 27, 2013

flashembed.js still has the svn keywords and other unexpanded vars: https://github.com/flowplayer/flash/blob/master/core/src/javascript/flashembed.js
These would go into the unminified flowplayer.js if it was built. In theory they also should persist in the minified version as flashembed.js could also be used standalone - if jquerytools was still actively maintained ...

@phloxic
Copy link
Author

phloxic commented Dec 27, 2013

Proposal:

/**
 * Flashembed - New wave Flash embedding
 *
 * NO COPYRIGHTS OR LICENSES. DO WHAT YOU LIKE.
 */

for the non-minified version - removed automatically in the minified version.

@phloxic
Copy link
Author

phloxic commented Dec 27, 2013

@anssip - the copyright year is still 2008-2011 in flowplayer-src.js

@phloxic
Copy link
Author

phloxic commented Dec 27, 2013

@anssip - now all version information is removed from the scripts.
It would be better if the build scripted added the release version and release date - as it is done for the fp html5 api.

phloxic added a commit to flowplayer/flash that referenced this issue Dec 27, 2013
This is still not ideal. The build script should:
- add release version and number to all published JS files
  flowplayer/flash-build#7
- create and publish the unminified api
  flowplayer/flash-build#6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants