Add support for external SVG files on both IOS and Android #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we please get this one merged? |
lsyer
added a commit
to lsyer/cordova-httpd
that referenced
this pull request
Oct 22, 2019
…tpot#70 [guycalledseven/cordova-httpd]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implemntation of httpd on both IOS (CocoaHttpd) and Android (NanoHTTPD) lack support for loading external SVG files. If SVG is included inline - everything works, but external ones do not show at all.
I have:
updated default-mimetypes from NanoHttpd/nanohttpd for Android (https://github.com/NanoHttpd/nanohttpd/blob/fd80618e93d17f8f05e11006eaa048a22213714d/core/src/main/resources/META-INF/nanohttpd/default-mimetypes.properties)
included IOS fix by @HungryShadow from issue Break SVG loading #54
The results are captured below.
Best
Neven
IOS
before
after
android
before
after