Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps filter #473

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Sep 7, 2023

  1. refactor: separate GMaps process from format

    Make GMapsDurationProcessor export unformatted data as
    well, to enable later steps in the pipeline (such as filters) to
    access and process this data.
    colinemondswieprecht committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1dad3d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. fix unit test on Windows

    You can't re-open a NamedTemporaryFile on Windows while it's still open.
    colinemondswieprecht committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1c5f36b View commit details
    Browse the repository at this point in the history
  2. feature flathunters#472: filter based on GMaps distance

    This PR involves some refactoring. The problem is that previously,
    filters ran before making any calls to external APIs. Therefore, just
    adding another filter for the distance doesn't actually work: the
    distance information is not yet available when we apply the filters. We
    can't just run the filters later, because then we would run the Google
    Maps API calls before we filtered out any properties, meaning that we
    would incur Google Maps API calls for all properties that we find in our
    search, including those that we later filter out anyway based on price,
    size, etc. - and we actually have to pay for those requests! My solution
    is to group the filters in two chains, and then run one chain before and
    one after external API calls have been made. This way, we can run the
    distance filter after the API calls are made, but keep everything else
    the same.
    colinemondswieprecht committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8a85d82 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    74d41fc View commit details
    Browse the repository at this point in the history