Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Preprocessing tests to lit #1052

Open
LukeIreland1 opened this issue Mar 6, 2020 · 2 comments
Open

Convert Preprocessing tests to lit #1052

LukeIreland1 opened this issue Mar 6, 2020 · 2 comments

Comments

@LukeIreland1
Copy link
Contributor

Preprocessing tests need to be converted to run with lit, like the other Fortran tests.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 6, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
8dba9a1 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 6, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
8180882 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 6, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
4f904ce 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 8, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
e922882 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 9, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
6eca025 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 10, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
1892e66 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 10, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
180dd12 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 10, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
c2266f3 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 10, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
7abb6e9 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 11, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
c4165a0 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 12, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
6d33f1a 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 13, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
5043d4a 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
LukeIreland1 added a commit to LukeIreland1/f18 that referenced this issue Mar 13, 2020
@LukeIreland1
Added CMakeLists changes, moved config and made test scripts compatible.
3f99d35 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
Sameeranjoshi pushed a commit to Sameeranjoshi/f18 that referenced this issue Mar 24, 2020
@LukeIreland1 @Sameeranjoshi
Added CMakeLists changes, moved config and made test scripts compatible.
fecdec2 
All Fortran tests are now run in lit, except Preprocessing tests flang-compiler#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.
swift-ci pushed a commit to swiftlang/llvm-project that referenced this issue Apr 9, 2020
@LukeIreland1
[flang] Added CMakeLists changes, moved config and made test scripts …
da9d002 
…compatible.

All Fortran tests are now run in lit, except Preprocessing tests flang-compiler/f18#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.

Original-commit: flang-compiler/f18@3f99d35
Reviewed-on: flang-compiler/f18#1027
@DavidTruby
Copy link
Collaborator

@RichBarton-Arm is this complete?

@RichBarton-Arm
Copy link
Contributor

No, the tests in the test/Preprocessing directory are not ported to lit yet. These tests were never being run on F18 and we tell lit to ignore them right now.

The tests are execution tests, i.e. they build Fortran snippets that run and print Pass/Fail messages. Each test relies on some functionality from the preprocessor being correctly honoured in order for the Pass message to print.

It should not be necessary to compile and run the test in order to check the preprocessor. I would expect tests on the output of -E should be sufficient and more desirable because they isolate the preprocessor so would not fail due to any subsequent issue unrelated to the preprocessor. I think this should be done at the same time as making these lit tests so in reality this might be more than a port, more a re-write/consolidate and porting job.

mem-frob pushed a commit to draperlaboratory/hope-llvm-project that referenced this issue Oct 7, 2022
@LukeIreland1
[flang] Added CMakeLists changes, moved config and made test scripts …
40d4761 
…compatible.

All Fortran tests are now run in lit, except Preprocessing tests flang-compiler/f18#1052
Preprocessing tests are a separate kind of test, so will be sorted out
later.

Original-commit: flang-compiler/f18@3f99d35
Reviewed-on: flang-compiler/f18#1027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DavidTruby @RichBarton-Arm @LukeIreland1