Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_ui_auth] Do not throw an exception if provider icon is not found in ProfileScreen #383

Open
1 task done
Rexios80 opened this issue Aug 20, 2024 · 4 comments
Open
1 task done
Labels
auth Needs Attention OP created or responded to issue and it needs attention.

Comments

@Rexios80
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues and found no duplicates.

What plugin is this bug for?

Firebase UI Auth

What platform(s) does this bug affect?

No response

List of dependencies used.

Not relevant

Steps to reproduce

  • Sign in with OIDC
  • Display the ProfileScreen
  • See that there is an error getting the icon for the OIDC provider

Expected Behavior

One of the following:

  • Ignore the providers with missing icons
  • Extract the icons from the providers

Actual Behavior

Error getting the icon for the OIDC provider breaks the UI

Additional Information

No response

@Rexios80 Rexios80 changed the title [firebase_ui_auth] Use provider icon for ProfileScreen if the provider is not a known one (ex OIDC) [firebase_ui_auth] Do not throw an exception if provider icon is not found in ProfileScreen Aug 20, 2024
@russellwheatley
Copy link
Member

hey @Rexios80 - please provide a code snippet I can easily drop into my main.dart file that reproduces this behaviour.

@russellwheatley russellwheatley added auth blocked: customer response Waiting for customer response, e.g. more information was requested. labels Sep 4, 2024
@Rexios80
Copy link
Contributor Author

Rexios80 commented Sep 4, 2024

I get this exception when using an OidcProvider provider from https://pub.dev/packages/firebase_ui_oauth_oidc. An example would require setting up an OIDC provider in the FIrebase console.

@russellwheatley russellwheatley added Needs Attention OP created or responded to issue and it needs attention. and removed blocked: customer response Waiting for customer response, e.g. more information was requested. labels Oct 25, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale Issue with no recent activity label Nov 22, 2024
@Rexios80
Copy link
Contributor Author

This is still an issue. I might try and set up an example, but that will take some effort.

@github-actions github-actions bot removed the Stale Issue with no recent activity label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Needs Attention OP created or responded to issue and it needs attention.
Projects
None yet
Development

No branches or pull requests

2 participants