-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to change max file size #51
Conversation
Hey, thanks for your PR. I'm wondering if it would be more appropriate to add this to the command line arguments (like |
I choose environment variable because;
|
Yes, then maybe we can add this to both arg and config? Because I don't want users to configure otree in two places (bash/fish config and otree.toml), which can easily lead to omissions. |
max file size moved from environment variable.
I don't know how default config was generated, so I add new option manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! One last thing, after some consideration, it seems more appropriate to call it max_data_size
, as there is still a limitation even without reading data from a file.
You can directly apply my suggestions.
how I can use otee without specifying file? |
Use pipe: xxxx | otree -t yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ccoVeille Hey, do you have further suggestions? |
no, I just want to explore some dataset(large dataset) |
No description provided.