Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Finch under finch/finch (instead of finagle/finch)? #975

Open
vkostyukov opened this issue Aug 10, 2018 · 4 comments
Open

Move Finch under finch/finch (instead of finagle/finch)? #975

vkostyukov opened this issue Aug 10, 2018 · 4 comments
Labels
Milestone

Comments

@vkostyukov
Copy link
Collaborator

vkostyukov commented Aug 10, 2018

This may help with discoverability. I don't really have a strong preference at the moment but eager to hear what people think.

As a side bonus we can have a little nicer URL for a website: https://finch.github.io - I'm not super sure though we can't already do that.

@vkostyukov vkostyukov added this to the Finch 0.24 milestone Aug 10, 2018
@vkostyukov vkostyukov changed the title Move finch under finch/finch (instead of finagle/finch)? Move Finch under finch/finch (instead of finagle/finch)? Aug 10, 2018
@frgomes
Copy link

frgomes commented Aug 11, 2018

This would be a good opportunity for consolidating internal/external dependencies across the entire suite of projects. At the moment, a certain project A depends on X.x whilst a certain project B depends on X.y. We have to eye-ball several projects in order to avoid jar hell. Ideally, all internal/external version numbers should be sitting on a single place, shared across the entire suite.

@ghost
Copy link

ghost commented Aug 13, 2018

@vkostyukov I don't see a lot of reason to prefer com.github.finagle to com.github.finch or io.finch as the groupId for new releases as long as there are warnings (and perhaps dual publishing) I personally like having finagle in some part of the the name but that's just due to me being used to it. If there ends up being wide agreement to move I'd prefer io.finch as it's what the code uses now.

@sergeykolbasov
Copy link
Collaborator

It'll damage SEO for some time, but in a long-term sense it should be better.

@vkostyukov
Copy link
Collaborator Author

vkostyukov commented Aug 13, 2018

I created https://issues.sonatype.org/browse/OSSRH-41890 so we can register io.finch group id and start publishing Finch there (even before we move).

UPDATE: We couldn't do io.finch as a group id as we don't own finch.io domain. I opted in for io.github.finch for now.

@vkostyukov vkostyukov modified the milestones: Finch 0.24, Finch 0.25 Sep 14, 2018
@vkostyukov vkostyukov modified the milestones: Finch 0.25, Finch 1.0 Oct 2, 2018
@vkostyukov vkostyukov modified the milestones: Finch 1.0, Finch 0.26 Oct 21, 2018
@vkostyukov vkostyukov modified the milestones: Finch 0.26, Finch 1.0 Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants