Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SectorSet serialization #3007

Closed
ZenGround0 opened this issue Jul 1, 2019 · 1 comment
Closed

Fix SectorSet serialization #3007

ZenGround0 opened this issue Jul 1, 2019 · 1 comment

Comments

@ZenGround0
Copy link
Contributor

Description

refmt can't handle maps with uint64 keys
In order to have a map with sectorID keys in the miner actor we currently convert uint64s to strings first. This is annoying because we open up the possibility of erroring when turning a map key back into a uint64.

Acceptance criteria

Some options here

  1. refmt implements this feature
  2. we move to using a different type to represent sectorIDs. Recent discussion on max sector id suggests we can fit them in uint16s.
  3. This problem will likely go away on its own once we have use a tree based SectorSet data structure because we will no longer use go maps to represent the data structure in memory.

Risks + pitfalls

Where to begin

@anorth
Copy link
Member

anorth commented Jul 24, 2019

To be obsoleted by #2888

@anorth anorth closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants