Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Costes randomization occurs over bounding box of ROI instead of ROI region itself #75

Open
andmccall opened this issue Jul 22, 2022 · 3 comments

Comments

@andmccall
Copy link

Randomization occurs over the bounding box of the ROI regardless of which selection method is used (normal ROI, mask, or ROI manager). This can have a significant difference on the results, leading to more false positives. Can be tested using the plugin itself by checking the "Display Shuffled images" button.

Also, I noticed that Coloc2 applies a smoothing function to the randomized data. In my testing on my plugin I noticed that smoothing also leads to more false positives. Might be worth looking into.

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/coloc-2-threshold-varies-widely-across-timepoints/69429/7

@andmccall
Copy link
Author

I should probably mention too that I have a functioning costes randomizer class that only randomizes within the defined region, and that you could probably integrate with Coloc2. I'm not the best programmer, so it probably needs some polishing:

https://github.com/andmccall/Colocalization_by_Cross_Correlation/blob/master/src/main/java/CostesRandomizer.java

@ctrueden
Copy link
Member

Thanks @andmccall, I appreciate it! I will try to come around to this issue when I can, but my queue is rather absurdly long. Previous developers of Coloc 2 including @tomka and @etadobson are not on the project anymore, so it will fall to me, unless someone in the community is able to file a PR to fix this issue in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants