Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Assertion error in supplemental or secondary reads #31

Closed
mrvollger opened this issue Nov 14, 2023 · 3 comments · Fixed by #47
Closed

Bug: Assertion error in supplemental or secondary reads #31

mrvollger opened this issue Nov 14, 2023 · 3 comments · Fixed by #47
Labels
bug Something isn't working

Comments

@mrvollger
Copy link
Member

Currently, there is a bug with handling ONT supplemental or secondary alignments in the ML/MM parser. I think it is due to hard clipping but need to investigate.

@mrvollger mrvollger added the bug Something isn't working label Nov 14, 2023
@mrvollger
Copy link
Member Author

mrvollger commented Nov 14, 2023

A temporary workaround is to filter your inputs to remove these types of alignments (samtools view -F 2304)

@mrvollger
Copy link
Member Author

Errors look like:

[2023-10-31T18:43:32Z TRACE ft] TRACE logging enabled
[2023-10-31T18:43:32Z DEBUG ft] Using 30 threads.
[2023-10-31T18:43:32Z INFO  ft] Starting ft-center
[2023-10-31T18:43:32Z DEBUG bio_io] Compression: No
[2023-10-31T18:43:32Z TRACE fibertools_rs::fiber] cb380dce191d20804ee54cfe86c4173384172d61_dna_r10.4.1_e8.2_400bps_sup@v4.2.0-44EB653E
[2023-10-31T18:43:32Z TRACE fibertools_rs::fiber] cb380dce191d20804ee54cfe86c4173384172d61_dna_r10.4.1_e8.2_400bps_sup@v4.2.0-5FF52E97
[2023-10-31T18:43:32Z TRACE fibertools_rs::fiber] cb380dce191d20804ee54cfe86c4173384172d61_dna_r10.4.1_e8.2_400bps_sup@v4.2.0-44ED6DDD
thread 'thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
 left: `0`,
 right: `4319`', src/basemods/mod.rs<unnamed>' panicked at ':166:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
assertion failed: `(left == right)`
 left: `0`,
 right: `2530`', src/basemods/mod.rs:166:17
thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
 left: `0`,
 right: `7916`', src/basemods/mod.rs:166:17

@mrvollger
Copy link
Member Author

Correct handling of MM/ML tags in hard clipped alignments is still not settled in the SAM spec:

samtools/hts-specs#646

So this will remain an issue until this conversation is resolved.

Please filter any hard clipped reads before using ft.

@mrvollger mrvollger mentioned this issue Mar 21, 2024
mrvollger added a commit that referenced this issue Mar 21, 2024
* feat: adds a check for and skips any reads with hard clipping. Fixes
#31.
* chore: general cleaning of the docs and help messages
* fix: embed the states of the onnx models to avoid file missing errors
with m6A prediction commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant