Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for exporting to OpenSearch #288

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wild5r
Copy link

@wild5r wild5r commented Oct 2, 2024

here is support for exporting to OpenSearch. The current integration with ElasticSearch was not compatible with the latest version of OpenSearch, despite the APIs being roughly similar

@fhamborg
Copy link
Owner

Thanks for the PR. Already with previous additions of export capabilities to more and more 3rd party systems, I had the thought that plainly adding all these individual systems to NP's export may at some point in time lead to a non-optimal situation. Specifically, I'm worried about having all these dependencies in setup.py and requirements.txt as well as the code additions requiring maintenance - whereas most users either don't use any of them or if at all only one.

Now adding another one, which is even just a variant of one that is already supported by NP (and AFAIK not hugely popular in comparison), raises theses thoughts even more so. I'm thinking that NP should probably come without any export functionality aside from JSON export and instead export functionality should be added

  1. either using pip extras (such as, pip install news-please[opensearch])
  2. or individual pip packages (such as, pip install news-please news-please-opensearch)

Excited to hear what the community thinks about this.

@wild5r
Copy link
Author

wild5r commented Oct 18, 2024

Optionally, we can adapt the export to JSON for use with any ingestion tools like Beats, Logstash, and so on. This way, we can remove the code for some exporters and add examples of configuring ingestion tools to the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants