New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In new arch, make Layer operations return Result instead of panicking internally #185

Open

hweom opened this issue Jan 8, 2023 · 0 comments

Labels

Contributor

hweom commented Jan 8, 2023

Instead of

pub trait Layer<B: IBackend>: Debug {
    fn compute_output(&self, backend: &B, context: &mut Context);
    fn compute_gradients(&self, backend: &B, context: &mut Context);
}

we would have

pub trait Layer<B: IBackend>: Debug {
    fn compute_output(&self, backend: &B, context: &mut Context) -> Result<(), LayerError>;
    fn compute_gradients(&self, backend: &B, context: &mut Context) -> Result<(), LayerError>;
}

hweom added the enhancement label

hweom mentioned this issue

Add softmax layers and convert MNIST example #184

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment