Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match http module API #27

Open
fbbdev opened this issue Jul 16, 2023 · 0 comments
Open

Match http module API #27

fbbdev opened this issue Jul 16, 2023 · 0 comments
Assignees
@fbbdev
Labels
breaking-change Fixing the issue requires a breaking change enhancement

Comments

@fbbdev
Copy link
Owner

fbbdev commented Jul 16, 2023

The http module's server constructor and createServer methods may optionally take as first argument an object with stream and socket options. node-fastcgi's constructor takes options as the last argument and ignores stream and socket settings. We should match the official API.
@fbbdev fbbdev self-assigned this Jul 16, 2023
@fbbdev fbbdev added bug enhancement breaking-change Fixing the issue requires a breaking change and removed bug labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbbdev fbbdev

Labels
breaking-change Fixing the issue requires a breaking change enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fbbdev