fix: Async key provider and errors should be resolved internally #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaIT
commented
Apr 2, 2024
| } else { | ||
| const verifyResult = verifier(token) | ||
| callback(null, verifyResult) |
There was a problem hiding this comment.
verifyResult moved in order to support promise based result.
| } | ||
| }) | ||
| fastify.get('/', async function (request, reply) { | ||
| request.headers.jwt = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.hQOxra1Zo9z61vCqe6_86kVfLqKI0WxDnkiJ_upW0sM' |
There was a problem hiding this comment.
Hardcoded request.headers.jwt is for key=this secret reused from cache
Generated with https://jwt.io/
There was a problem hiding this comment.
please generate this dynamically in code.
NikitaIT
changed the title
mcollina
requested changes
Apr 22, 2024
| }) | ||
| fastify.get('/', async function (request, reply) { | ||
| request.headers.jwt = | ||
| 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c' |
There was a problem hiding this comment.
please generate this dynamically in code.
| } | ||
| }) | ||
| fastify.get('/', async function (request, reply) { | ||
| request.headers.jwt = 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.hQOxra1Zo9z61vCqe6_86kVfLqKI0WxDnkiJ_upW0sM' |
There was a problem hiding this comment.
please generate this dynamically in code.
| }) | ||
| fastify.get('/', async function (request, reply) { | ||
| request.headers.jwt = | ||
| 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c' |
There was a problem hiding this comment.
please generate this dynamically in code.
Merged
4 tasks
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
jwt.js:490
- [nitpick] The variable 'verifyResult' is declared but not initialized. Consider initializing it.
let verifyResult
jwt.js:534
- Ensure that all error cases handled by the 'wrapError' function are covered by tests.
function wrapError (error, callback) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
False positive tests: test: Async key provider errors should be resolved internally
Fix & test fix: feat: Async key provider
Related issue: #334
Checklist
npm run testandnpm run benchmarkand the Code of conduct