Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve events reader get Uris with dictionary instead of list #44

Open
edgarriba opened this issue Nov 18, 2022 · 0 comments
Open

[Feature] Improve events reader get Uris with dictionary instead of list #44

edgarriba opened this issue Nov 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@edgarriba
Copy link
Member 

    @Hackerman342 @ethanrublee i have a proposal here to improve the current api and make it more user friend.

Random access here might be error prone, we could make it via dictionary and use the key as the semantics of the uri.

uris: Dict[str, uri_pb2.Uri] = reader.uris()
uri: uri_pb2.Uri = uris["oak0/video"]

Originally posted by @edgarriba in farm-ng/farm-ng-amiga#31 (comment)
@edgarriba edgarriba added the enhancement New feature or request label Nov 18, 2022
@edgarriba edgarriba changed the title Improve events reader Uris with dictionary instead of list [Feature] Improve events reader Uris with dictionary instead of list Nov 18, 2022
@edgarriba edgarriba mentioned this issue Nov 18, 2022
Merged
@edgarriba edgarriba changed the title [Feature] Improve events reader Uris with dictionary instead of list [Feature] Improve events reader get Uris with dictionary instead of list Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edgarriba