Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for creating LabeledVideoDataset from video frames #207

Open
fcakyon opened this issue Jun 16, 2022 · 1 comment · May be fixed by #208
Open

add support for creating LabeledVideoDataset from video frames #207

fcakyon opened this issue Jun 16, 2022 · 1 comment · May be fixed by #208
Assignees
@kalyanvasudev
Labels
enhancement New feature or request

Comments

@fcakyon
Copy link

fcakyon commented Jun 16, 2022

Currently, Video object can be constructed from a video folder that contains video frames:

pytorchvideo/pytorchvideo/data/frame_video.py

Line 115 in 08a1fce

def from_frame_paths(

However, LabeledVideoDataset cannot be created from video frames since LabeledVideoPaths class does not support that:

pytorchvideo/pytorchvideo/data/labeled_video_dataset.py

Line 296 in 08a1fce

labeled_video_paths = LabeledVideoPaths.from_path(data_path)

To solve this issue, from_path method of the LabeledVideoPaths

pytorchvideo/pytorchvideo/data/labeled_video_paths.py

Line 19 in 08a1fce

def from_path(cls, data_path: str) -> LabeledVideoPaths:
can be extended so that it can handle video frames.
@fcakyon fcakyon linked a pull request Jun 16, 2022 that will close this issue
Open
11 tasks
@kalyanvasudev kalyanvasudev added the enhancement New feature or request label Aug 12, 2022
@kalyanvasudev kalyanvasudev self-assigned this Aug 12, 2022
@kalyanvasudev
Copy link
Contributor

Thanks for working this! I will review the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalyanvasudev kalyanvasudev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for creating LabeledVideoDataset from video frames fcakyon/pytorchvideo
2 participants
@kalyanvasudev @fcakyon