Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator.reset should change default_lighting_key to point to scene instance lighting setup #2453

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simulator.reset should change default_lighting_key to point to scene instance lighting setup #2453

wants to merge 1 commit into from

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 19, 2024

Motivation and Context

Moved this change from #2451 for closer evaluation in isolation and unit test updates.

How Has This Been Tested

CI
TODO: requires changes to unit test GT images.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 August 19, 2024 18:43
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 19, 2024
@aclegg3 aclegg3 mentioned this pull request Aug 19, 2024
Merged
11 tasks
@jturner65 jturner65 changed the base branch from main to dev September 18, 2024 17:23
@jturner65
Copy link
Contributor

Changed this to merge into the dev branch

Base automatically changed from dev to main November 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 Awaiting requested review from jturner65

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @jturner65 @facebook-github-bot