add support for fixed parameters #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66012863 |
JasonKChow
force-pushed
the
export-D66012863
branch
from
bfd9e3e
to
e0b6c77
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
Summary: Pull Request resolved: facebookresearch#457 Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output. Differential Revision: D66012863
|
This pull request was exported from Phabricator. Differential Revision: D66012863 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 18, 2024
Summary: Pull Request resolved: facebookresearch#457 Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output. Differential Revision: D66012863
JasonKChow
force-pushed
the
export-D66012863
branch
from
e0b6c77
to
6237327
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66012863 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66012863 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 19, 2024
Summary: Pull Request resolved: facebookresearch#457 Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output. Differential Revision: D66012863
JasonKChow
force-pushed
the
export-D66012863
branch
from
6237327
to
c3a1c49
Compare
Summary: Pull Request resolved: facebookresearch#445 Discrete parameter support added via rounding transform. Differential Revision: D65699942
…okresearch#452) Summary: Pull Request resolved: facebookresearch#452 Transforming bounds requires additional logic that used to be part of ParameterTransforms, we move these to the parameters itself and have the ParameterTransforms look for these special methods when transforming bounds. We add a new ABC for our transforms as going forward it is likely that all of our transforms will have unique capabilities over the BoTorch base. Differential Revision: D65897908
JasonKChow
force-pushed
the
export-D66012863
branch
from
c3a1c49
to
1c6acd6
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
Summary: Pull Request resolved: facebookresearch#457 Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output. Reviewed By: crasanders Differential Revision: D66012863
|
This pull request was exported from Phabricator. Differential Revision: D66012863 |
Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
… tensors Summary: This removes the numpy dependency from the manual generators and changes the logic slightly so that we can support higher dimensional tensors of points, allowing us to support pairwise experiments Differential Revision: D64607853
Summary: Binary parameters are just secretly discrete parameters bounded at [0, 1]. Config will accept binary as a par_type and do the necessary work to support it in modeling. Differential Revision: D65954134
Summary: Add new parameter error that only is ever raised in config to allow meaningful error handling when parameter options aren't set correctly. ValueError for missing bounds/parameter names is still there to handle fallbacks but incorrectly set options will throw the new error. Differential Revision: D65957107
|
This pull request was exported from Phabricator. Differential Revision: D66012863 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
Summary: Pull Request resolved: facebookresearch#457 Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output. Reviewed By: crasanders Differential Revision: D66012863
JasonKChow
force-pushed
the
export-D66012863
branch
from
1c6acd6
to
0711018
Compare
Summary: Pull Request resolved: facebookresearch#457 Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output. Reviewed By: crasanders Differential Revision: D66012863
JasonKChow
force-pushed
the
export-D66012863
branch
from
0711018
to
589d95b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66012863 |
|
This pull request has been merged in deb8ce1. |
JasonKChow
added a commit
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: #457 Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output. Reviewed By: crasanders Differential Revision: D66012863 fbshipit-source-id: 9d5720b2f3acaf547c18269d762808dccc7a3383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for fixed parameters. These parameters are just set in the config and will be removed before any model or generator is aware of them (then added back in whenever a model or generator is asked for an output.
Differential Revision: D66012863