Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out transform classes/functions to new files #453

Closed
wants to merge 3 commits into from
Closed

Split out transform classes/functions to new files #453

wants to merge 3 commits into from

Commits on Nov 20, 2024

  1. Add support for discrete parameters (facebookresearch#445) 

    Summary:

Discrete parameter support added via rounding transform.

Reviewed By: crasanders

Differential Revision: D65699942
    @JasonKChow @facebook-github-bot
    JasonKChow authored and facebook-github-bot committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    89e9bb3 View commit details
    Browse the repository at this point in the history

  2. Make a transform base class for consistent API (facebookresearch#452) 

    Summary:

Transforming bounds requires additional logic that used to be part of ParameterTransforms, we move these to the parameters itself and have the ParameterTransforms look for these special methods when transforming bounds.

We add a new ABC for our transforms as going forward it is likely that all of our transforms will have unique capabilities over the BoTorch base. This includes how we handle some finding options from configs.

Reviewed By: crasanders

Differential Revision: D65897908
    @JasonKChow @facebook-github-bot
    JasonKChow authored and facebook-github-bot committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    70ff235 View commit details
    Browse the repository at this point in the history

  3. Split out transform classes/functions to new files (facebookresearch#453 

    )

Summary:

parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py

New parameter handling overwrites old ax support, so we remove ax related functions/tests

Reviewed By: crasanders

Differential Revision: D65898366
    @JasonKChow @facebook-github-bot
    JasonKChow authored and facebook-github-bot committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    be300df View commit details
    Browse the repository at this point in the history