Split out transform classes/functions to new files #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65898366 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
force-pushed
the
export-D65898366
branch
from
462e9a7
to
9fe7a02
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65898366 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 14, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 15, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Differential Revision: D65898366
JasonKChow
force-pushed
the
export-D65898366
branch
from
9fe7a02
to
c54ca36
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65898366 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 19, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
JasonKChow
force-pushed
the
export-D65898366
branch
from
c54ca36
to
858e9d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65898366 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
Summary: Discrete parameter support added via rounding transform. Reviewed By: crasanders Differential Revision: D65699942
Summary: Transforming bounds requires additional logic that used to be part of ParameterTransforms, we move these to the parameters itself and have the ParameterTransforms look for these special methods when transforming bounds. We add a new ABC for our transforms as going forward it is likely that all of our transforms will have unique capabilities over the BoTorch base. This includes how we handle some finding options from configs. Reviewed By: crasanders Differential Revision: D65897908
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 20, 2024
) Summary: parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366
JasonKChow
force-pushed
the
export-D65898366
branch
from
858e9d3
to
b3523b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65898366 |
JasonKChow
force-pushed
the
export-D65898366
branch
from
b3523b5
to
be300df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65898366 |
|
This pull request has been merged in f2be1a1. |
JasonKChow
added a commit
that referenced
this pull request
Nov 25, 2024
Summary: Pull Request resolved: #453 parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py New parameter handling overwrites old ax support, so we remove ax related functions/tests Reviewed By: crasanders Differential Revision: D65898366 fbshipit-source-id: ccc38cbad782a90c732106bae26825564e5ca408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
parameters.py was getting too big. Transforms themselves were moved to ops.py, leaving the base class and wrapper classes in parameters.py. Generic utility function that could be used elsewhere moved to base utils.py
New parameter handling overwrites old ax support, so we remove ax related functions/tests
Differential Revision: D65898366