pass transforms around instead of making duplicates #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 29, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
e79aa21
to
5ee0660
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 30, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
2 times, most recently
from
b85b9fb
to
fb39cf3
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 30, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 30, 2024
…#416) Summary: Pull Request resolved: facebookresearch#416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
fb39cf3
to
5130a3d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 31, 2024
…#416) Summary: Pull Request resolved: facebookresearch#416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
5130a3d
to
4ff2276
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 31, 2024
…#416) Summary: Pull Request resolved: facebookresearch#416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
2 times, most recently
from
b300da4
to
f503e5f
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 31, 2024
…#416) Summary: Pull Request resolved: facebookresearch#416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 1, 2024
…#416) Summary: Pull Request resolved: facebookresearch#416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
f503e5f
to
010af92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 1, 2024
…#416) Summary: Pull Request resolved: facebookresearch#416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
010af92
to
ed9e919
Compare
JasonKChow
force-pushed
the
export-D65155103
branch
from
938435a
to
e07fdbe
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Pull Request resolved: facebookresearch#416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
e07fdbe
to
dc32e2a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
dc32e2a
to
f31ccd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
f31ccd9
to
89f8bce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 8, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
89f8bce
to
241f206
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
…earch#443) Summary: All parameters will have some options that will always be the same. We add a private function that unifies this. Differential Revision: D65695127
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
force-pushed
the
export-D65155103
branch
from
241f206
to
d0c3258
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65155103 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 9, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 9, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Nov 11, 2024
…#416) Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Differential Revision: D65155103
|
This pull request has been merged in 901de00. |
crasanders
pushed a commit
that referenced
this pull request
Nov 14, 2024
Summary: Pull Request resolved: #416 Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects. Reviewed By: crasanders Differential Revision: D65155103 fbshipit-source-id: 6350857e70d8abc6229bb556f746ad53ea4abe30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Instead of creating duplicate transforms whenever we need one, we create a single transform from the config and initialize the wrapped model and wrapped generators with that one transform. This passes the same transform object around and allows the transformations to learn parameters and still be synced up across wrapped objects.
Differential Revision: D65155103