-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feedback component to loading page #888
Conversation
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
- Coverage 64.65% 64.60% -0.06%
==========================================
Files 108 108
Lines 9312 9312
==========================================
- Hits 6021 6016 -5
- Misses 3291 3296 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@EricMichaelSmith Is this kind of what you expected? |
This is cool! Only issue is that the most common reason this happens is because the mephisto router is alive, but the Mephisto server that was associated with it no longer is connected. After #829 however then this would cover the actual loading use cases. |
Yeah! This is really cool to see, and it'll let us get feedback about broken HITs. I feel like, in my experience, emails about broken HITs are at least as common as all other email topics put together... |
This is a clever use case for the new Feedback component! I would suggest a 10 second delay, 5 seems a little too quick to me. It would also be nice to have the timeout value as a constant, and perhaps we can expose that at the top of the |
✏️ Fixed typo 'propertly' -> 'properly' ⏳ Increased feedback box timeout from 5000ms -> 10000ms
Hi @Etesam913! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Overview
A very common circumstance where feedback might want to be received is during loading.
There are times where a task my be stuck in loading forever. The researcher should be able to know directly if a large chunk of workers are not able to see the task.
This was brought up to me by @EricMichaelSmith
Changes:
Video
feedback-on-loading.mp4