Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused arguments and imports #98

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Proyag
Copy link

@Proyag Proyag commented Oct 7, 2019

  • Removed unused lower_case argument in Token and TokenLine
  • Removed unused (and confusing) line argument in BPEfastLoad
  • Removed unused imports in mine_bitexts.py
  • Removed MOSES_LC in text_processing.py which pointed to the no longer used Moses lowercasing script

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 7, 2019
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@hoschwenk hoschwenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for cleaning up the code !
I would prefer to keep the lower_case flag even though it is currently not used.
Future version of LASER may be case sensitive :-)

@Proyag
Copy link
Author

Proyag commented Oct 22, 2019

Fair enough. Reverted those changes.

@Proyag Proyag requested a review from hoschwenk October 22, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants