Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add guide to keep title of caution admonitions #9695

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Jan 4, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

There are some use cases where “warning” is too strong. This PR provides how to refactor :::caution with its title kept as is.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#9307

@tats-u tats-u requested a review from slorber as a code owner January 4, 2024 09:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 4, 2024
Copy link

netlify bot commented Jan 4, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 976f07b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/659680edc7fe570008f1faf5
😎 Deploy Preview https://deploy-preview-9695--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 4, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 74 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 4, 2024
@slorber
Copy link
Collaborator

slorber commented Jan 4, 2024

thanks 👍

@slorber slorber merged commit 332a466 into facebook:main Jan 4, 2024
11 checks passed
@tats-u tats-u deleted the rewrite-caution branch January 4, 2024 10:20
tats-u added a commit to tats-u/docusaurus that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants