Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database initialisation function using RXdb #6

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

JasonWarrenUK
Copy link
Collaborator

@JasonWarrenUK JasonWarrenUK commented Nov 27, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Installed rxdb and rxjs packages in package.json
  • Created rxdb.ts with database initialisation function
  • Merge with main pwa pull request

Screenshots

Please replace this line with any relevant images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: tested locally on index page that database can initialise, test shall be written once there is an implementation
  • I need help with writing tests

What gif best describes this PR or how it makes you feel?

alt_text

@maxitect maxitect marked this pull request as ready for review November 27, 2024 13:02
@maxitect maxitect changed the title feat: 🚧 initial setup of database Database initialisation function using RXdb Nov 27, 2024
Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls see comments

Tick the correct box in the what type of change is this section, add a gif and I can approve

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@JasonWarrenUK JasonWarrenUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this script still apply? I thought that node can't run the db as it needs to run in the client?

@maxitect can you respond to Jack's comments? You made the most recent changes and I don't wana get it wrong

@jackcasstlesjones jackcasstlesjones merged commit 88bb080 into main Nov 27, 2024
1 check failed
@JasonWarrenUK JasonWarrenUK deleted the build/integrate-RxDB_8696uk759 branch November 27, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants