Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jason warren/mood data #12

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Jason warren/mood data #12

merged 5 commits into from
Nov 27, 2024

Conversation

JasonWarrenUK
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Initial implementation of the input aspects of the mood page

  • MoodPage (including NeuroChemContext)
    • Cube
    • SliderBar
      • Slider
  1. Moodpage calls SliderBar
  2. SliderBar calls 3 instances of Slider, passing a string prop to each
  3. Slider pulls the neurochemical that corresponds to its string prop from the context
    • When the Slider is moved...
    • it sends its numeric value...
    • to the state of the neurochemical in the context
  4. Cube watches the neurochemicals in the context. When one changes, it updates its display

Screenshots

CleanShot.2024-11-27.Wednesday.at.5.13.50.Arc.mp4

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues? don't know what this is, not looking at it now
  • Color contrast tested? nope, didn't specify colours myself

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I WILL ALWAYS need help with writing ALL tests PLEASE JACK

What gif best describes this PR or how it makes you feel?

Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, question about whether to use interfaces as standard, commit suggestions or challenge :)

src/app/moods/page.tsx Outdated Show resolved Hide resolved
src/app/moods/components/Slider.tsx Outdated Show resolved Hide resolved
@JasonWarrenUK
Copy link
Collaborator Author

Looks great, question about whether to use interfaces as standard, commit suggestions or challenge :)

Totally agree, accepting now. Good catch, thankyou.

@maxitect maxitect merged commit ad3e081 into main Nov 27, 2024
1 check failed
@JasonWarrenUK JasonWarrenUK deleted the Jason-Warren/Mood-Data branch November 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants