Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve git-bash and powershell support #23

Open
ath0mas opened this issue May 10, 2020 · 4 comments
Open

Improve git-bash and powershell support #23

ath0mas opened this issue May 10, 2020 · 4 comments

Comments

@ath0mas
Copy link

ath0mas commented May 10, 2020

It seems interactive use of bump does not work on Windows.

  • with git-bash, command stops as soon as interactive prompt is expected to be displayed, showing "Cannot read property 'get' of undefined" and exiting
  • with powershell, first interactive prompt is displayed, validated, action is applied on project, but command stays like waiting for input not following nor exiting

basic setup:

mkdir bump-foo && cd bump-foo
npm init private && git init && git add . && git commit -m "initial commit"

then trying
bump fails:

                $ npx bump
(git-bash)
                Cannot read property 'get' of undefined
(powershell)
                ? Select an increment: (Use arrow keys)
                  major
                > minor
                  patch
                  premajor
                  preminor
                  prepatch
                  prerelease
                  custom
                ? Select an increment: minor

bump minor fails:

                $ npx bump minor
(git-bash)
                Bumping the version...
                Updating the changelog...
                Cannot read property 'get' of undefined
(powershell)
                ? No changes detected, bump anyway? (Use arrow keys)
                  No
                > Yes
                ? No changes detected, bump anyway? Yes
                Bumping the version...

bump minor --force runs fine 😃:

                $ npx bump minor --force
                Bumping the version...
                Updating the changelog...
                Making the commit...
                Tagging the commit...

environment:

  • Windows 10
  • Node 14.2.0 Current / 12.16.3 LTS
  • NPM 6.14.4
@fabiospampinato fabiospampinato added bug Something isn't working help wanted Extra attention is needed labels May 10, 2020
@fabiospampinato fabiospampinato changed the title Unable to execute interactive 'bump' on Windows Improve git-bash and powershell support May 10, 2020
@fabiospampinato
Copy link
Owner

@ath0mas could you try if v3 fixes this for you?

@ath0mas
Copy link
Author

ath0mas commented Sep 2, 2023

Not much time for now but sure I'll try v3 in 10 days or so 👍

@ath0mas
Copy link
Author

ath0mas commented Sep 14, 2023

Working fine with git-bash and powershell! 👍


To report about my tests:

  • with my previous setup, I always have ✖ Unsupported repository ; looking into the code, I found that a package.json without a name entry is rejected
    • so I manually add a name into my package.json and it works
  • then I get stuck with an infinite Tagging the commit message :/ ; stopping it results in the commit to have been created but no tag
$ bump
✔ Select an increment: minor
✔ No changes detected, bump anyway? Yes
✔ Version bumped to "0.2.0" successfully
✔ Commit made successfully
- Tagging the commit...

@fabiospampinato
Copy link
Owner

fabiospampinato commented Mar 22, 2024

@ath0mas to glarify, the Tagging the commit step is still not working properly for you on the latest version of this package, right?

@fabiospampinato fabiospampinato removed bug Something isn't working help wanted Extra attention is needed labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants