Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Implement set/get methods for api keys instead constants #133

Open
shakaran opened this issue Jun 20, 2016 · 3 comments
Open

Implement set/get methods for api keys instead constants #133

shakaran opened this issue Jun 20, 2016 · 3 comments

Comments

@shakaran
Copy link

As per doc and exception messages show, it recommends to configure the ApiKeys.php files for example for use Mozscape service with the ACCESS_ID and secret code.

The problem with this if you install through composer it will generate in vendor/seostats/seostats/SEOstats/Config/ApiKeys.php a file, if I edit the file, it could be overwritten in future with new SEOstats versions and I cannot set dinamically in code for different mozscape keys since it is treated as a constant.

So, it would be nice if we have a get/set method in api keys, so it could be configured in execution time.

@eyecatchup
Copy link
Owner

You can now use DotEnv for ApiKeys. See #131

@shakaran
Copy link
Author

@eyecatchup this is a better solution, but it doesn't satisfy really my issue. When I want use several API keys in execution time it always will load the same .env file or I am forced to rewrite the .env file in execution time, so for me this change is not really solving my issue

@eyecatchup
Copy link
Owner

OK, get it. I see what I can do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants