Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 fastify/busboy hangs #1280

Open
mysuf opened this issue Nov 3, 2024 · 0 comments
Open

v2 fastify/busboy hangs #1280

mysuf opened this issue Nov 3, 2024 · 0 comments
Labels

Comments

@mysuf
Copy link

mysuf commented Nov 3, 2024

@LinusU I noticed that you are using @fastify/busboy instead of original one for streaming variant 2.x.x. I faced hangs during mixed fields+file multipart upload and I found out that fastify implementaion is buggy and doesn't properly handle streams which results in hangs (end/finish/error/close not triggered). When I switched to original busboy, it just works and all events are triggered as expected (I tried it also without multer mw). It is hard to provide reproducible example as there are too many variables (nginx/apache, browser, multipart content etc), but I wanted to just pointed this out as it deserves your attention. Thanks.

P.S I also noticed that lts uses some really prehistoric version of busboy. Maybe it would be worth it to bump version.

@mysuf mysuf added the bug label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant