-
-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mentor notes layout: Suggested comments should wrap, otherwise not readable #2203
Comments
On the other hand, I find having them on a single line makes them much easier to copy/paste into a bulleted list of suggestions. |
Would it be possible to have them wrap only for display purposes, but be on
one line for copy/paste purposes?
Like this text here, if you copy it, it's one-lined:
https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap
I wouldn't copy something that I haven't read.
…On Mon, Jun 27, 2022 at 8:18 PM Isaac Good ***@***.***> wrote:
On the other hand, I find having them on a single line makes them much
easier to copy/paste into a bulleted list of suggestions.
—
Reply to this email directly, view it on GitHub
<#2203 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF77AQPYENAUUFUGCVL244DVRHV5ZANCNFSM5Z7HWKQA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@corneliusroemer - Highlighting a part of the text triggers a sideways scrollbar in the UI (at least it does on my MBP running Monterey, and did when it ran Mojave): That being said, its not ideal, but its not entirely cut off either. |
@BethanyG yes, it does scroll, but it's still pretty much unreadable from a UX standpoint - yes I could technically read it, but in practice I won't, because it's a lot of pain. Easier to copy/paste to a Google doc to do that. For code, this is sort of OK, though it would be good to have all code have max line width of say 60-80 chars and the box to be that width, in usual viewports. For text that is 600 chars wide, it just shouldn't live in the code fences the way they're implemented right now. Does anyone actually read them as they are? Scrolling horizontally? This is the whole text:
Here's the file in question: https://github.com/exercism/website-copy/blob/main/tracks/python/exercises/rna-transcription/mentoring.md |
They are optimized for copy paste over reading. The code blocks make it easier to have backticks and other markdown meta chars embedded in the text. If you want to reformat that to not live in a code block but still contain markdown meta chars which can be copy pasted, I'd be happy to see improvements to these notes. |
The suggested comments in mentor notes are useful, but not really usable, because they are in non-wrapping code-blocks.
There are two possibilities:
As it stands, it's quite bad, see how this appears on my 16" MBP display, it overflows a lot:
The text was updated successfully, but these errors were encountered: