Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion about type annotations #4

Open
nifadyev opened this issue Aug 27, 2024 · 1 comment
Open

Discussion about type annotations #4

nifadyev opened this issue Aug 27, 2024 · 1 comment

Comments

@nifadyev
Copy link
Contributor

Let's discuss improvements and changes related to type annotations
If you have any experience, example, or snippet to share, feel free to suggest it into this discussion.
@nifadyev
Copy link
Contributor Author

My suggestion is to strongly encourage type annotations for new code and annotate existing codebase whenever possible. It is also advised to use mypy/pyright on pre-commit or CI stage but allow proceeding with invalid annotations because sometimes it takes a lot of effort to debug and annotate code.

@nifadyev nifadyev mentioned this issue Sep 19, 2024
Merged
soltanoff added a commit that referenced this issue Sep 19, 2024
@soltanoff
Merge pull request #8 from nifadyev/feature/#4/add-recommendation-abo…
4975114 
…ut-type-annotations

#4: Add recommendation about type annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nifadyev