Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie: Better Structured & Expanded Checkpointing Tests #3701

Closed
holgerd77 opened this issue Sep 25, 2024 · 0 comments · Fixed by #3705
Closed

Trie: Better Structured & Expanded Checkpointing Tests #3701

holgerd77 opened this issue Sep 25, 2024 · 0 comments · Fixed by #3705

Comments

@holgerd77
Copy link
Member

holgerd77 commented Sep 25, 2024

This is a follow-up on #3645, post by @TimDaub.

So the mentioned issue is about trie failures in the context of checkpointing usage. I guess the only realistic way that we can catch this respectively generally make this part of Trie more robust is by expanding on the checkpointing tests from here.

These are not as structured and do not cover as much the complete range of combinations as the lot more structured StateManager tests.

So I guess the best way is to somewhat more align and roughly (trie adopted with key/values for sure) the labelling mechanism from the SM tests (e.g. A1.1 -> CP -> A1.2 -> Revert -> Flush() (-> A1.1)) and then inject/integrate the existing trie checkpointing tests (or: move over) and then see which cases are left and fully add these as new tests.

(this would be generally good to have this, since if we identify a new missing combination in the future in one of the libraries, it get's a lot easier to just directly add to the other)

From my intuition I would guess chances are somewhat high that we discover 1-2 bugs by this (> 50%, we'll see).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant