Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompose the interface #798

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Decompose the interface #798

wants to merge 2 commits into from

Conversation

tjungblu
Copy link
Contributor

trying to decouple the interface a bit further, inversing the interface injection again.

/hold

drafting for now, happy to discuss/split the different pieces out

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjungblu
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Decompose the interface
00c8969 
trying to decouple the interface a bit further, inversing the interface
injection again.

Signed-off-by: Thomas Jungblut <[email protected]>
@tjungblu
Split serialization into composition
2f5d584 
This also moves out copyall, removes the duplicated reload function,
adds a more general list func.

Signed-off-by: Thomas Jungblut <[email protected]>
@tjungblu
Copy link
Contributor Author

Second commit is breaking the serialization out of the freelist interface, copyall becomes an implementation detail of it and the txchecker now uses a simplified listing function instead.

@k8s-ci-robot
Copy link

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-bbolt-test-4-cpu-arm64 2f5d584 link true /test pull-bbolt-test-4-cpu-arm64
pull-bbolt-test-4-cpu-race-arm64 2f5d584 link true /test pull-bbolt-test-4-cpu-race-arm64
pull-bbolt-test-2-cpu-arm64 2f5d584 link true /test pull-bbolt-test-2-cpu-arm64
pull-bbolt-robustness-arm64 2f5d584 link true /test pull-bbolt-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/L
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjungblu @k8s-ci-robot