You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wouldn’t consider the mail client a model. In your model, there is no such thing as a mail client. This is a traditional service and I wouldn’t put it into the Model package. The separation between the client and the helper is also very confusing. A constructor should not be called “setup”. Then every mail has the same subject, which welcomes the user. This should definitely not be hardcoded in the “helper”. I would redesign that quite heavily.
The text was updated successfully, but these errors were encountered:
Review:
I wouldn’t consider the mail client a model. In your model, there is no such thing as a mail client. This is a traditional service and I wouldn’t put it into the Model package. The separation between the client and the helper is also very confusing. A constructor should not be called “setup”. Then every mail has the same subject, which welcomes the user. This should definitely not be hardcoded in the “helper”. I would redesign that quite heavily.
The text was updated successfully, but these errors were encountered: