Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob pattern excludes package #923

Open
1 task done
wkoot opened this issue Nov 14, 2024 · 0 comments
Open
1 task done

Glob pattern excludes package #923

wkoot opened this issue Nov 14, 2024 · 0 comments

Comments

@wkoot
Copy link

wkoot commented Nov 14, 2024

Check for existing issues

  • Completed

Environment

Github workflow:

    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: errata-ai/[email protected]
        with:
          fail_on_error: true
          filter_mode: nofilter
          vale_flags: "--glob='!styles *.md'"

Vale version latest default, with .vale.ini:

StylesPath = styles
MinAlertLevel = suggestion
Vocab = Base
Packages = proselint

[*.md]
BasedOnStyles = Vale, proselint

Describe the bug / provide steps to reproduce it

The glob pattern seems to exclude the proselint package from vale entirely, instead of only omitting it from the linting selection:

Installed reviewdog from 'https://github.com/reviewdog/reviewdog/releases/download/v0.17.0/reviewdog_0.17.0_Linux_x86_64.tar.gz' into '/home/runner/reviewdog'.
/home/runner/vale --glob='!styles/ *.md' sync
E100 [loadStyles] Runtime error
style 'proselint' does not exist on StylesPath
Execution stopped with code 1.

I'm trying to exclude the styles folder entirely, since it's throwing errors unrelated to what I want to lint:

  {"message": "[Vale.Spelling] Did you really mean 'Suchow'?", "location": {"path": "styles/proselint/README.md", "range": {"start": {"line": 1, "column": 31}}}, "severity": "ERROR"}
  {"message": "[Vale.Spelling] Did you really mean 'Redistributions'?", "location": {"path": "styles/proselint/README.md", "range": {"start": {"line": 6, "column": 4}}}, "severity": "ERROR"}
  {"message": "[Vale.Spelling] Did you really mean 'Redistributions'?", "location": {"path": "styles/proselint/README.md", "range": {"start": {"line": 8, "column": 4}}}, "severity": "ERROR"}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant