Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to source code from API docs not working #368

Open
benhutchison opened this issue Nov 3, 2022 · 9 comments
Open

Links to source code from API docs not working #368

benhutchison opened this issue Nov 3, 2022 · 9 comments

Comments

@benhutchison
Copy link

To repro:

@erikerlandson
Copy link
Owner

Thanks for reporting!
@armanbilge is there a sbt configuration for this in the unidocs subproject that I'm missing?

@armanbilge
Copy link
Contributor

@benhutchison
Copy link
Author

@armanbilge this is what I see:
image

Feels like a CORS or similar issue that may vary by browser..?

@armanbilge
Copy link
Contributor

Ah, thanks. That's weird, it looks like it's trying to open the link in a javadoc.io iframe or something instead of actually browsing to there 🤔

@armanbilge
Copy link
Contributor

@benhutchison do you have the same issue with the Cats docs?
https://www.javadoc.io/doc/org.typelevel/cats-docs_2.13/latest/cats/Monad.html

@benhutchison
Copy link
Author

It works for Monad. However, one difference is the link opens in a new tab, not the same tab as for Coulomb,

@armanbilge
Copy link
Contributor

Thanks. So seems like it's a Scala 3 dottydoc issue.

@armanbilge
Copy link
Contributor

@erikerlandson
Copy link
Owner

@armanbilge thanks for tracking that down! (FWIW, those links also aren't working for me)

ckipp01 pushed a commit to scala/scala3 that referenced this issue Mar 4, 2023
Context:
- erikerlandson/coulomb#368

This seems to be necessary so that the source links work with
javadoc.io. Note that Scaladoc 2 sets `target="_blank"`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants